util: fix OSC 8 hyperlink stripping in stripVTControlCharacters

[dushyant-hada-90]

Fixes: #64313

Summary

The bundled ansi-regex OSC pattern used by stripVTControlCharacters() relied on a restrictive URI character class that failed when OSC 8 hyperlink URIs contained RFC 3986-valid characters such as (, ), !, +, [ and ].

This updates OSC handling to match sequences generically as:

ESC ] ... ST

aligned with ansi-regex v6.2.0.

Problem

stripVTControlCharacters() failed to correctly strip OSC 8 hyperlinks whose URI contained characters omitted from the previous regex character class:

[-a-zA-Z\d/#&.:=?%@~_]

Example:

import { stripVTControlCharacters } from 'node:util';

const link =
  '\u001B]8;;https://example.com/(foo\u0007label\u001B]8;;\u0007';

console.log(stripVTControlCharacters(link));

Actual

ttps://example.com/(foo\u0007label

Expected

label

The OSC match terminated early at (, leaving most of the escape sequence in the output.

Changes

• Replace the restrictive OSC URI matcher with generic OSC matching up to the first string terminator (BEL, ESC \, or 0x9C)
• Sync the bundled regex behavior with ansi-regex v6.2.0
• Preserve existing CSI handling logic

Tests

Added regression coverage in:

test/parallel/test-util-stripvtcontrolcharacters.js

for OSC 8 hyperlinks containing:

• (
• )
• !
• +
• [ ]

across all supported OSC string terminators.

Notes

• Existing CSI handling is unchanged
• Fast-path behavior is unchanged
• Embedded OSC terminators inside URIs retain previous behavior

[Archkon]

not complete consistent with
(?:;\d{0,4})*
(?:[;:]\d{0,4})*

[dushyant-hada-90]

Pushed updates addressing the feedback:

Accepted the [;:] CSI parameter separator suggestion (@Archkon) and reworded the commit to follow commit message guidelines
Added regression tests for the remaining RFC 3986 characters ($ ' * ,), colon-delimited CSI sub-parameters, and an unterminated-OSC edge case

Verified the final regex against every added test case and confirmed it now matches upstream ansi-regex v6.2.0 exactly.
Ready for another look

[dushyant-hada-90]

Hi @Archkon, @avivkeller
I've addressed all the feedback from both rounds. The resolved threads are all closed and the regex now matches ansi-regex v6.2.0 exactly. Would really appreciate a re-review or an approval when you get a chance. Happy to make any further changes!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/75131/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (00917ba) to head (a40efe2).
⚠️ Report is 78 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #64319    +/-   ##
========================================
  Coverage   90.14%   90.14%            
========================================
  Files         741      743     +2     
  Lines      242076   242322   +246     
  Branches    45558    45645    +87     
========================================
+ Hits       218216   218445   +229     
+ Misses      15385    15361    -24     
- Partials     8475     8516    +41     

Files with missing lines	Coverage Δ
lib/internal/util/inspect.js	96.93% <100.00%> (-0.01%)	⬇️

... and 80 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dushyant-hada-90]

I have updated the commit message to comply with the Node.js commit guidelines, since the previous message was failing CI.
Kindly re-approve CI when convenient.
@avivkeller