http: add IPv6 range support for NO_PROXY environment variable - #59950
http: add IPv6 range support for NO_PROXY environment variable#59950haramj wants to merge 2 commits into
Conversation
|
Review requested:
|
82b9bef to
397aac8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59950 +/- ##
==========================================
- Coverage 90.15% 90.15% -0.01%
==========================================
Files 744 744
Lines 242542 242577 +35
Branches 45690 45700 +10
==========================================
+ Hits 218672 218697 +25
- Misses 15362 15370 +8
- Partials 8508 8510 +2
🚀 New features to boost your workflow:
|
|
This pull request has been marked as stale due to 90 days of inactivity. |
|
@haramj Can you please rebase, sign the first commit and force push? It's required as per updated instructions
|
Signed-off-by: haramjeong <04harams77@gmail.com>
Signed-off-by: haramjeong <04harams77@gmail.com>
e8735e8 to
e6bf6c6
Compare
Thanks! I’ve rebased the branch onto the latest main and added the required Signed-off-by line to both commits. |
|
@trivikr It looks like the failing test is unrelated to this change (parallel/test-repl-use-global failed with ERR_INSPECTOR_COMMAND in the BoringSSL shared-library job). Could someone please rerun the failed job? |
This PR resolves the
// TODO(joyeecheung): support IPv6.comment ininternal/http.jsby adding comprehensive support for IPv6 address ranges to theNO_PROXYenvironment variable.Previously, the
ProxyConfigclass'sshouldUseProxymethod could only handle IPv4 address ranges. With this change, users can now specify IPv6 ranges (e.g.,::1-::100) to correctly bypass proxies for hosts within those ranges.The implementation involves:
ipv6ToBigIntto convert 128-bit IPv6 addresses intoBigInts for reliable numerical comparison.shouldUseProxylogic to check if a host is within a given IPv6 range.This update ensures the proxy bypass feature is robust and consistent with both IPv4 and IPv6 network standards.
New test cases have been added to
test/client-proxy/test-http-proxy-request-no-proxy-ipv6.mjsto verify the new functionality.Test
::1-::100) correctly bypasses the proxy.This ensures that the new feature works as expected and does not introduce regressions to existing functionality.
/cc @joyeecheung