Skip to content

[CO][20260910-0204] Remove unused previewRobotTag and serviceDocLink - #429

Merged
nocoo merged 1 commit into
mainfrom
co/20260910-basalt-cleanup
Sep 9, 2026
Merged

[CO][20260910-0204] Remove unused previewRobotTag and serviceDocLink#429
nocoo merged 1 commit into
mainfrom
co/20260910-basalt-cleanup

Conversation

@nocoo

@nocoo nocoo commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove unused site-private helpers previewRobotTag and serviceDocLink from src/lib/site.ts.
  • Trim helper-only assertions in src/lib/site.test.ts; keep renderHeaders coverage for service-doc Link and absence of X-Robots-Tag.

Why

  • Repo-wide search showed zero production call sites (only the unit test imported them).
  • Worker hardcodes X-Robots-Tag: noindex; renderHeaders already inlines the service-doc Link header.
  • Not part of published @nocoo/basalt API.

Verification

  • bun run test — 1873 passed / 3 skipped
  • Pre-commit hooks (typecheck, lint, coverage, osv-scanner) passed
  • Codex targeted re-run: site/edge/worker tests 22 passed
  • Codex SIGN-OFF: "Safe removal of unused internal exports."

不改变现有业务行为

Dead site-private helpers with no production call sites; renderHeaders
and worker already cover service-doc / noindex behavior.
@cloudflare-workers-and-pages

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
theme-basalt 39180ca Commit Preview URL

Branch Preview URL
Sep 09 2026, 06:12 PM

@nocoo
nocoo merged commit 21b4b20 into main Sep 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant