Skip to content

fix: update cfg_aliases dependency to version 0.2.2 - #2808

Open
xtqqczze wants to merge 1 commit into
nix-rust:masterfrom
xtqqczze:semicolon_in_expressions_from_macros
Open

fix: update cfg_aliases dependency to version 0.2.2#2808
xtqqczze wants to merge 1 commit into
nix-rust:masterfrom
xtqqczze:semicolon_in_expressions_from_macros

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

needed to fix semicolon_in_expressions_from_macros error in minver

error: trailing semicolon in macro used in expression position
  --> build.rs:4:5
   |
 4 | /     cfg_aliases! {
 5 | |         android: { target_os = "android" },
 6 | |         dragonfly: { target_os = "dragonfly" },
 7 | |         ios: { target_os = "ios" },
...  |
27 | |         solarish: { any(illumos, solaris) },
28 | |     }
   | |_____^
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
   = note: `#[deny(semicolon_in_expressions_from_macros)]` (part of `#[deny(future_incompatible)]`) on by default
   = note: this error originates in the macro `$crate::cfg_aliases` which comes from the expansion of the macro `cfg_aliases` (in Nightly builds, run with -Z macro-backtrace for more info)

@xtqqczze

Copy link
Copy Markdown
Contributor Author

@SteveLauC PTAL

needed to fix semicolon_in_expressions_from_macros error in minver

```log
error: trailing semicolon in macro used in expression position
  --> build.rs:4:5
   |
 4 | /     cfg_aliases! {
 5 | |         android: { target_os = "android" },
 6 | |         dragonfly: { target_os = "dragonfly" },
 7 | |         ios: { target_os = "ios" },
...  |
27 | |         solarish: { any(illumos, solaris) },
28 | |     }
   | |_____^
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #79813 <rust-lang/rust#79813>
   = note: `#[deny(semicolon_in_expressions_from_macros)]` (part of `#[deny(future_incompatible)]`) on by default
   = note: this error originates in the macro `$crate::cfg_aliases` which comes from the expansion of the macro `cfg_aliases` (in Nightly builds, run with -Z macro-backtrace for more info)
   ```
@xtqqczze
xtqqczze force-pushed the semicolon_in_expressions_from_macros branch from 7bbfcf8 to c14579d Compare August 30, 2026 17:03
@xtqqczze

xtqqczze commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

@asomers Can you merge this?

@asomers

asomers commented Sep 8, 2026

Copy link
Copy Markdown
Member

@xtqqczze it LGTM, but we need to fix CI first. Also, even if we merge this, I don't see any need for a patch release. After all, consumers can easily fix any warnings by updating cfg_aliases in their own projects.

@xtqqczze

xtqqczze commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

@xtqqczze it LGTM, but we need to fix CI first.

This is required to fix the minver job in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants