Add infinite-scroll furni grid to InventoryFurniView using new Scrollbar component - #10
Open
billsonnn wants to merge 2 commits into
Open
Add infinite-scroll furni grid to InventoryFurniView using new Scrollbar component#10billsonnn wants to merge 2 commits into
billsonnn wants to merge 2 commits into
Conversation
…bar component Scrollbar draws Nitro's own track/thumb/up-down-button art over a real overflow-y:auto element, exposing onScrollEnd for pagination and forwarding a ref to the scrollable node for virtualizers. InventoryFurniView uses it with @tanstack/react-virtual to paginate a furni grid; real inventory data isn't wired up yet (FurniListEventMessage is still a stub), so items are synthesized from real catalog classnames as a clearly-marked placeholder. Also fixes two pre-existing bugs that were silently breaking all themed UI: - TabContent had no bounded height, so tab content overflowed instead of scrolling (now flex-1 min-h-0 with overflow-hidden). - Every asset folder under assets/images was PascalCase while theme.css references them lowercase, 404ing every background/border image on a case-sensitive filesystem. Renamed all folders to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017N3QN64RQkS3mP1w6EkLGg
… view Dropmenu becomes a real dropdown: click/keyboard to open, DropmenuItem rows in a bordered popover (reusing Scrollbar for long lists), controlled or uncontrolled selection, closes on select/outside-click/Escape. Wired into InventoryFurniView as a working floor/wall/all filter. Extracted the furni grid's virtualization into a generic ItemGrid component that takes a renderItem prop, so any item shape/visual can be plugged in instead of the previously hardcoded FurnitureImage markup. Also fixes a real bug found while testing the new filter: `pool.push(...map.values())` silently dropped every element when the target array started empty, wiping out the wall/floor pool. Replaced with Array.from(...).concat(...). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017N3QN64RQkS3mP1w6EkLGg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.