add server framework detection and overrides for tanstack - #3
Closed
HomelessDinosaur wants to merge 1 commit into
Closed
add server framework detection and overrides for tanstack#3HomelessDinosaur wants to merge 1 commit into
HomelessDinosaur wants to merge 1 commit into
Conversation
tjholm
reviewed
Jun 9, 2026
| // so railpack serves the build output as a static SPA. Nitro emits a server | ||
| // at .output/server/index.mjs (same as Nuxt). @tanstack/start is the old name. | ||
| if c.pkg.hasAnyDependency("@tanstack/react-start", "@tanstack/solid-start", "@tanstack/start") { | ||
| return serverFramework{Name: "TanStack Start", StartCmd: "node .output/server/index.mjs"}, true |
Member
There was a problem hiding this comment.
Should this use the detected runtime? If the railpack output uses a bun base image for the runtime as an example this will fail as node will not be available
HomelessDinosaur
force-pushed
the
NIT-1230
branch
from
June 9, 2026 02:01
9dac970 to
649f63e
Compare
Member
Author
|
When this PR gets merged this can be closed and have a different approach using the custom providers. railwayapp/railpack#588 |
HomelessDinosaur
marked this pull request as draft
June 15, 2026 03:25
tjholm
pushed a commit
that referenced
this pull request
Aug 14, 2026
* fix: bump railpack to v0.36.4 so Vite server apps deploy TanStack Start apps failed with `"/app/dist": not found`: detection saw Vite, concluded static site, and looked for a dist the app never produces. TanStack Start detection landed upstream in railpack v0.36.0, thirteen minor versions ahead of the v0.23.0 we vendored. - railpack v0.23.0 -> v0.36.4 (moby/buildkit v0.28.1 -> v0.32.2 with it) - NewBuildGraph gained a noCache arg, so --no-cache now reaches the graph - GenerateBuildPlan now returns an error for transient failures only; report those differently from a deterministic planning failure - RAILPACK_VERSION is read from build info, so it cannot disagree with go.mod - the plan step now states the static-site assumption and how to override it, before the build that would fail on it - dependabot gives railpack its own weekly PR rather than a grouped bump - detection tests over TanStack Start (with and without a start script) and plain Vite fixtures Closes NIT-1655. Also covers NIT-1230, whose closed PR #3 hand-rolled the detection upstream now does. * test: drop framework detection fixtures Framework detection is railpack's to test. Keep the tests covering our own handling of the plan it produces: the static-site warning, the output dirs it names, and the version we report. * refactor: drop node-specific static site warning from the plan path Per review: the version bump should land on its own, and node-specific guidance does not belong in the hot path for every build. The warning is better placed alongside package analysis that can name the framework it actually found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.