Clamp download progress to 100%#235
Open
araidz wants to merge 1 commit into
Open
Conversation
Progress.fractionCompleted can exceed 1.0 when the server delivers more bytes than the expected Content-Length (e.g. resumed downloads), causing the activity view to display values like "103.00% completed". Clamp currentValue at the source so every consumer (progress bar, percentage text, byte count) stays capped at 100%. Fixes ninxsoft#222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #222 ("More than 100%").
Progress.fractionCompletedcan exceed1.0when the server delivers more bytes than the expectedContent-Length(e.g. on resumed downloads). The activity view then renders values like103.00% completed. SwiftUI'sProgressViewclamps the bar internally, but the percentage label and the "X of Y bytes" label read the raw value directly, so they overshoot.Fix
Clamp
currentValueat its single source inDownloadManagerso every consumer (progress bar, percentage text, byte count) stays capped at 100%:Verification
Reproduced the exact scenario with the same
ProgressAPI (completed 103 of expected 100 units):Valid mid-download values (e.g. 50%) pass through unchanged.