Fix handling non trivial stream reads in async framer - #32
Open
mmcomando wants to merge 1 commit into
Open
Conversation
This fixes cases: - Stream returns only part of a websocket frame - Stream returns only part of websocket frame header - There is no way to tell if framer can progress without reading from stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes cases:
In my embedded app I have found out that using async framer doesn't work, when a lot of data is sent.
Async framer works only if stream read returns only one complete frame.
If stream returns to little or too much data then I had problems with framer.
There is also a problem when stream returns only part of websocket frame header, in that case framer can't progress further.
I don't have much experience with async rust streams so maybe this can be done better.
Code in my app which works after this patch: