WIP: Configure rustfmt hex_literal_case - #571
Open
nikobockerman wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Rust formatting configuration to enforce consistent casing for hexadecimal literals across the Rust solver codebase.
Changes:
- Introduces
hex_literal_case = "Upper"in the Rust solver’srustfmt.tomlto standardize hex literal formatting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nikobockerman
force-pushed
the
configure-rustfmt-hex-literal-case
branch
from
August 22, 2026 14:40
5c6c719 to
9ae5aa5
Compare
This configuration option is recently stabilized and defaults to "Preserve". Configure it to "Upper" in order to have unified formatting in the repo.
nikobockerman
force-pushed
the
configure-rustfmt-hex-literal-case
branch
from
September 3, 2026 17:55
9ae5aa5 to
90da3af
Compare
nikobockerman
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated multi-line check:rustfmt script can still exit successfully even if cargo fmt --check fails, which can allow formatting regressions to pass CI.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This configuration option is recently stabilized and defaults to "Preserve". Configure it to "Upper" in order to have unified formatting in the repo.