Run the tests before the cross-compile - #5
Merged
Merged
Conversation
Neither reads the other's output: the build action cross-compiles and asks the binary for its version, and the test action formats, vets and tests the source. So the order decides one thing only -- which failure you hear about sooner -- and a vet or test failure is a more common way to break this than the cross-compile is. Nothing else changes here. setup-go already keeps a Go build cache and the run log shows it restoring, which is why this repository needs none of the cache work the mise-based ones did. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smallest slice of the fleet-wide Actions cleanup started in
astrylogical/astry#25. One reordering, no caching changes.Neither action reads the other's output — Build cross-compiles and asks the binary for its version, Test formats/vets/tests the source — so the order only decides which failure surfaces first, and a vet or test failure is the more common one.
Deliberately not here: any Go build cache.
actions/setup-goalready keeps one, confirmed in the run log:That is the difference between this repo and
ormos-be/cazper-be, which usemise-action— it installs the toolchain and caches nothing else, so a~/.cache/go-buildentry had to be added there by hand. Worth knowing as a fleet-level inconsistency: two toolchain-setup mechanisms with materially different caching behaviour.This repo runs in well under two minutes, so there is no meaningful wall-clock win here — the change is for consistency with the rest of the fleet and faster feedback on red runs.
🤖 Generated with Claude Code