Fix cache-control header for non-HTML sec-fetch-dest 404 route - #91
Closed
gaearon wants to merge 1 commit into
Closed
Fix cache-control header for non-HTML sec-fetch-dest 404 route#91gaearon wants to merge 1 commit into
gaearon wants to merge 1 commit into
Conversation
The dest is a static asset (/_next/static/not-found.txt), which gets a default public, cacheable Cache-Control header from the CDN unless overridden. This diverged from the Cache-Control Next.js itself sets for the equivalent response when the app is invoked directly.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Author
|
Superseded — folding this into a trunk-level fix plus a shared helper so PR #89's new route stays consistent with the pre-existing one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dest is a static asset (/_next/static/not-found.txt), which gets
a default public, cacheable Cache-Control header from the CDN unless
overridden. This diverged from the Cache-Control Next.js itself sets
for the equivalent response when the app is invoked directly.
Stack created with GitHub Stacks CLI • Give Feedback 💬