Fix outdated warning because of e2ee calls - #6671
Merged
Merged
Conversation
…abled Android previously showed a generic "outdated app" error whenever the server had end-to-end-encryption for calls enabled, since the server blocks unsupported client versions entirely. E2EE calling is not yet implemented on Android, so instead of blocking the whole app, detect the server's call E2EE capability and only warn the user when a call is actually started or answered, leaving the rest of the app usable. Mirrors the approach from talk-ios#2369. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
The heads-up notification shown for an incoming call that can't be answered because the server has call E2EE enabled previously used a generic title. Include the conversation name so the user can tell which conversation the call came from. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Collaborator
Author
|
/backport to stable-25.0.x |
3 tasks
mahibi
changed the title
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/34365354058/artifacts/10110854316 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #5892 until e2ee calls are possible
Show warnings when e2ee calls are enabled on server. They are not yet supported by the android talk app. But until now, the app show that it is outdated which is not true and confusing.
With this PR the app can be used for chatting but will show warnings when trying to call.
For this, a flag must be set on server to tell which android talk version "support" e2ee --> nextcloud/spreed#19352
How to test until the server change was made:
just set
Same solution as applied as for talk iOS:
nextcloud/talk-ios#2369
nextcloud/spreed#16955
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)