Skip to content

More relevant wordings (participant rights) #19348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jerome-Herbinet wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

More relevant wordings (participant rights) #19348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/react-permission-integration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ The backend migration automatically grants the REACT permission to all users who
## UI Changes

The permissions editor should show two separate checkboxes:
- "Can post messages" (CHAT - 128)
- "Can add reactions" (REACT - 256)
- "Post messages" (CHAT - 128)
- "Add reactions" (REACT - 256)

Instead of the previous combined "Can post messages and reactions" checkbox.
4 changes: 2 additions & 2 deletions src/components/PermissionsEditor/PermissionsEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@
<NcCheckboxRadioSwitch
v-model="chatMessages"
class="checkbox">
{{ hasReactPermissions ? t('spreed', 'Can post messages') : t('spreed', 'Can post messages and reactions') }}
{{ hasReactPermissions ? t('spreed', 'Post messages') : t('spreed', 'Post messages and reactions') }}
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch
v-if="hasReactPermissions"
v-model="chatReactions"
class="checkbox">
{{ t('spreed', 'Can add reactions') }}
{{ t('spreed', 'Add reactions') }}
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch
v-model="publishAudio"
Expand Down
4 changes: 2 additions & 2 deletions src/components/RightSidebar/Participants/ParticipantPermissionsEditor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ describe('ParticipantPermissionsEditor.vue', () => {
const permissionsMap = [
{ label: 'Start a call', value: !!(permissions & PARTICIPANT.PERMISSIONS.CALL_START) },
{ label: 'Skip the lobby', value: !!(permissions & PARTICIPANT.PERMISSIONS.LOBBY_IGNORE) },
{ label: 'Can post messages', value: !!(permissions & PARTICIPANT.PERMISSIONS.CHAT) },
{ label: 'Can add reactions', value: !!(permissions & PARTICIPANT.PERMISSIONS.REACT) },
{ label: 'Post messages', value: !!(permissions & PARTICIPANT.PERMISSIONS.CHAT) },
{ label: 'Add reactions', value: !!(permissions & PARTICIPANT.PERMISSIONS.REACT) },
{ label: 'Enable the microphone', value: !!(permissions & PARTICIPANT.PERMISSIONS.PUBLISH_AUDIO) },
{ label: 'Enable the camera', value: !!(permissions & PARTICIPANT.PERMISSIONS.PUBLISH_VIDEO) },
{ label: 'Share the screen', value: !!(permissions & PARTICIPANT.PERMISSIONS.PUBLISH_SCREEN) },
Expand Down
Loading