Skip to content

perf: make request to /contactsmenu/teams only when contacts menu is opened - #64141

Merged
cristianscheid merged 1 commit into
masterfrom
perf/noid/contacts-menu-teams-load
Sep 9, 2026
Merged

perf: make request to /contactsmenu/teams only when contacts menu is opened#64141
cristianscheid merged 1 commit into
masterfrom
perf/noid/contacts-menu-teams-load

Conversation

@cristianscheid

@cristianscheid cristianscheid commented Sep 9, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

  • a GET contactsmenu/teams request was being made on every page load
  • this happened because the endpoint was being called inside onMounted, and since the contacts menu is on the header of the page, every page load triggered it
  • moved the GET contactsmenu/teams request inside the onOpened function, so it's only triggered when the contacts menu is actually opened
  • with this fix, the request is only made when clicking on the contacts menu for the first time, subsequent openings of the menu do not trigger it again, only if the page is reloaded

for context, contacts menu:
image

changes look good from my tests, functionality keeps working as expected

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@cristianscheid
cristianscheid requested a review from a team as a code owner September 9, 2026 11:56
@cristianscheid
cristianscheid requested review from kristian-zendato, skjnldsv and sorbaugh and removed request for a team September 9, 2026 11:56
@cristianscheid cristianscheid self-assigned this Sep 9, 2026
Comment thread core/src/views/ContactsMenu.vue Outdated
@cristianscheid
cristianscheid force-pushed the perf/noid/contacts-menu-teams-load branch from a2dd3c4 to a6cb559 Compare September 9, 2026 12:56
@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable35

Comment thread core/src/views/ContactsMenu.vue Outdated
@cristianscheid
cristianscheid force-pushed the perf/noid/contacts-menu-teams-load branch from a6cb559 to 0809683 Compare September 9, 2026 13:32
…opened

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid
cristianscheid force-pushed the perf/noid/contacts-menu-teams-load branch from 0809683 to f6d42c4 Compare September 9, 2026 13:36

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now, thanks for addressing)

@cristianscheid
cristianscheid merged commit be16437 into master Sep 9, 2026
86 checks passed
@cristianscheid
cristianscheid deleted the perf/noid/contacts-menu-teams-load branch September 9, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants