perf: make request to /contactsmenu/teams only when contacts menu is opened - #64141
Merged
Merged
Conversation
cristianscheid
requested review from
kristian-zendato,
skjnldsv and
sorbaugh
and removed request for
a team
September 9, 2026 11:56
artonge
approved these changes
Sep 9, 2026
Antreesy
reviewed
Sep 9, 2026
cristianscheid
force-pushed
the
perf/noid/contacts-menu-teams-load
branch
from
September 9, 2026 12:56
a2dd3c4 to
a6cb559
Compare
Member
Author
|
/backport to stable35 |
Antreesy
reviewed
Sep 9, 2026
cristianscheid
force-pushed
the
perf/noid/contacts-menu-teams-load
branch
from
September 9, 2026 13:32
a6cb559 to
0809683
Compare
…opened Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
perf/noid/contacts-menu-teams-load
branch
from
September 9, 2026 13:36
0809683 to
f6d42c4
Compare
Antreesy
approved these changes
Sep 9, 2026
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Should be good now, thanks for addressing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET contactsmenu/teamsrequest was being made on every page loadonMounted, and since the contacts menu is on the header of the page, every page load triggered itGET contactsmenu/teamsrequest inside theonOpenedfunction, so it's only triggered when the contacts menu is actually openedfor context, contacts menu:

changes look good from my tests, functionality keeps working as expected
Checklist
3. to review, feature component)stable32)AI (if applicable)