[stable34] fix(metadata): bind chunked file ids in dropMetadataForFiles - #64092
Open
dispather wants to merge 1 commit into
Open
[stable34] fix(metadata): bind chunked file ids in dropMetadataForFiles#64092dispather wants to merge 1 commit into
dispather wants to merge 1 commit into
Conversation
Signed-off-by: dispather <62810211+dispather@users.noreply.github.com>
dispather
requested review from
Altahrim,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
September 7, 2026 09:15
CarlSchwan
approved these changes
Sep 7, 2026
susnux
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #62331 to
stable34.MetadataRequestService::dropMetadataForFiles()splits$fileIdsinto chunks of 1000 and iterates over them, but theINclause still binds the full$fileIdsarray instead of the current$chunk. Each iteration therefore issues the same full-sizeDELETE, which produces theMore than 1000 expressions in a list are not allowed on Oracle.entry fromQueryBuilder::prepareForExecute()and repeats an identical statement once per chunk.The sibling method
IndexRequestService::dropIndexForFiles()carried the same copy/paste bug and was already backported tostable34in #62771. This applies the equivalent one-line fix to the metadata table.Difference from the master patch
master's #62331 switches the chunk size to
IQueryBuilder::MAX_IN_PARAMETERS, which does not exist onstable34. This PR keeps the existing literal1000and changes only the bound variable, matching the shape of the already-mergedstable34backport #62771 (+1/-1, same file family).getMetadataFromFileIds()a few lines above also binds an unchunked$fileIds, but master's #62331 leaves it untouched as well, so it is out of scope here.Why this is filed by hand
/backport to stable34was requested on #62331 twice without response — in prose on 2026-08-08 and as the bot command on 2026-09-06. Both requesters haveauthor_association: NONE, so the command does not appear to be honoured from non-members. Filing manually rather than leavingstable34unpatched; happy to close this if backportbot is triggered by a maintainer instead.Refs #62331, #62771, #62325