Chore/upgrade vue 3#1933
Conversation
715dbd4 to
8d82acf
Compare
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de>
…odelValue Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
6bae2db to
7a76ef3
Compare
There was a problem hiding this comment.
failing playwright tests are relevant. I'm nervous about upgrading since Notes doesn't have a comprehensive test suite that could help us catch any issues. Could we have another PR that adds some more tests that cover more key workflows first, before we do the migration?
Hey @enjeck , yes I can do that. I would also do a separate PR for the Pinia migration, like @mejo- and @max-nextcloud suggested. |
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Nice, code changes look very promising so far ❤️ Thanks a lot for chunking the changes in easily reviewable commits, that makes it very pleasant to review 😊
| </template> | ||
| <template v-if="category.name !== ''" #actions> | ||
| <NcActionButton | ||
| :closeAfterClick="true" |
There was a problem hiding this comment.
Maybe that's for later, but :property="true" can get replaced with property on Vue components. So in this case this could become simply closeAfterClick (without the colon).
|
|
||
| import { generateFilePath } from '@nextcloud/router' | ||
|
|
||
| import { Fragment } from 'vue-frag' |
There was a problem hiding this comment.
I guess vue-frag can be removed from dependencies now?
| /> | ||
| </div> | ||
| <span class="action-buttons"> | ||
| <NcActions :open.sync="actionsOpen" container=".action-buttons" menu-align="right"> |
There was a problem hiding this comment.
We got these migrations wrong both in Collectives and in Text a few times. The changes look good to me, but I recommend to test the functionalities manually where .sync and/or v-model got touched to be on the safe side.
| <NcActionInput | ||
| v-else | ||
| :value="note.category" | ||
| :modelValue="note.category" |
There was a problem hiding this comment.
Same here. Code changes look good but I'd verify with a manual test.
Signed-off-by: silver <s.szmajduch@posteo.de>
4 participants
🚧 work in progress 🚧
Upgrade to Vue 3
...
🤖 AI (if applicable)