fix(tray): restore pause and resume sync action - #10529
Conversation
- Restores the global Pause sync for all / Resume sync for all action lost during the tray-menu migration. - Adds the action to both Qt and macOS root tray menus, between Add account and Settings. - Centralizes availability and behavior in Systray. - Hides the action when no classic sync folders exist, including macOS File Provider mode. - Preserves the previous behavior across all configured accounts. - Adds regression coverage for visibility, labels, and pause/resume behavior across two accounts. Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8e7a36ef2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #else | ||
| systray->toggleSyncPaused(); |
There was a problem hiding this comment.
In the macOS branch, the regression test calls toggleSyncPaused() directly and never constructs NCTrayPopup or activates the new NCActionRow, so the test still passes if the action is omitted, mislabeled, or disconnected in nctraypopup.mm. Add a test seam that verifies the macOS popup's visibility, title, and action callback instead of bypassing the platform UI wiring.
AGENTS.md reference: AGENTS.md:L205-L209
Useful? React with 👍 / 👎.
|
Artifact containing the AppImage: nextcloud-appimage-pr-10529.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
1 participant
Assisted-by: Codex:GPT-5
@kra-mo
this was a feature in the old user menu and was forgotten during migration.
I think we need to add it. Any objections?