fix(macOS): use tag to pass menu command to Finder extension. - #10528
Open
camilasan wants to merge 2 commits into
Open
fix(macOS): use tag to pass menu command to Finder extension.#10528camilasan wants to merge 2 commits into
camilasan wants to merge 2 commits into
Conversation
Member
Author
|
/backport to stable-34.0.0 |
camilasan
force-pushed
the
bugfix/finder-menu
branch
from
August 3, 2026 14:10
e0b219b to
a747173
Compare
camilasan
marked this pull request as ready for review
August 3, 2026 14:10
camilasan
requested review from
claucambra,
i2h3,
mgallien and
nilsding
as code owners
August 3, 2026 14:10
camilasan
changed the title
camilasan
force-pushed
the
bugfix/finder-menu
branch
from
August 3, 2026 14:13
a747173 to
c1ef1db
Compare
camilasan
changed the title
Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
camilasan
force-pushed
the
bugfix/finder-menu
branch
from
August 3, 2026 14:31
c1ef1db to
4672b25
Compare
camilasan
changed the title
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10528.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Member
Author
|
The tests failing here are passing locally for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There is a bug in macOS where it does not use/copy over the representedObject of a menu item. So we have to use tag instead. The tag was removed with xpc rewrite.
Checklist
AI (if applicable)