fix(viewer): show the modal when it carries only an error - #23
Merged
Conversation
skjnldsv
added
status: review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 36 36
Lines 2460 2460
Branches 501 502 +1
=======================================
Hits 2089 2089
Misses 368 368
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The modal renders on an error with no file, which is what an open that never got as far as a file leaves behind: `openFolder` on something that is not a folder, a listing that fails, an unknown handler id. Its `show` prop only followed the file though, and NcModal hides its content with `v-show`, so all of those ended as a click that appeared to do nothing. The stub the viewer tests mount honoured `show` no more than the viewer did, which is why every one of those cases looked reported. It mirrors the `v-show` now, and an error inside a hidden modal no longer counts. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/error-without-file
branch
from
September 10, 2026 17:05
48b1104 to
e1e0232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modal renders when there is an error and no file, which is what an open that never got as far as a file leaves behind:
openFolder()on something that is not a folder, a listing that fails, an unknown handler id,open([]). Itsshowprop only followedcurrentFilethough, and NcModal hides its content withv-show, so every one of those cases ended as a click that appeared to do nothing.The
NcModalStubthe viewer tests mount honouredshowno more than the viewer did, which is why all of those paths looked reported. It mirrors thev-shownow anderrorText()only returns a visible error, so the ten existing error tests fail without the one-line fix. The test that assertedshow === falsefor an unknown handler id now asserts that no handler was rendered instead.Not verified in a browser, only in jsdom.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.