fix: rate limiter cleanup on a time interval, not just key count#84
Open
Jaro-c wants to merge 1 commit into
Open
fix: rate limiter cleanup on a time interval, not just key count#84Jaro-c wants to merge 1 commit into
Jaro-c wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the
RateLimiterServicehalf of #77, not theplayer.local.tshalf — see my comment on the issue for why I split it.checkLimitonly rancleanup()oncethis.hits.size > 5000. Bursty player churn across manyclientId:class:methodkeys could transiently grow memory before that threshold is ever reached. Added a time-based trigger alongside the existing size one — cleanup now also runs if more than 60s have passed since the last one, regardless of key count.Added a test file for this service (there wasn't one) covering the basic limit/window behavior and the new interval-based cleanup trigger via fake timers.
pnpm test,pnpm typecheck, andpnpm checkall pass.Refs #77.