fix: validate scaffolded name on the CLI-arg path, not just the prompt#31
Open
Jaro-c wants to merge 1 commit into
Open
fix: validate scaffolded name on the CLI-arg path, not just the prompt#31Jaro-c wants to merge 1 commit into
Jaro-c wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I traced
getNameFromArgsOrPromptand noticed it returnedargs[0]without calling any validator when the name comes in as a CLI argument — the (weak, empty/space-only) validator invalidateCreateNameonly ran on the interactivehuhprompt path. A name like../../etc/foowould reachfilepath.Joinincreate_resource.go,create_standalone.go,init.go, andtemplates/embed.gounchecked.Replaced the space-only check with an allow-list regex (
^[a-zA-Z0-9_-]+$) and applied it on both paths — the CLI-arg path now validates before returning the name, same as the prompt path already did.Added tests for
validateCreateName(valid/invalid names, including traversal attempts) and forgetNameFromArgsOrPromptrejecting a traversal name passed as an argument.go build,go vet,gofmt -l, andgo test ./...all pass.Closes #24.