ci: add workflow running vet, fmt check and tests on push/PR#27
Open
Jaro-c wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed there was only
publish.yml, triggered onpush: tags: ["v*"]— nothing ran on push/PR tomasterordevelop. Code was merging with no lint/vet/test check, and the only test run (go test ./...) in the existing workflow is gated behindif: matrix.isPublisher, so it only executes for thewindows-amd64matrix leg — linux and darwin builds never ran tests, even at release time.Added a
ci.ymlthat runs on PR/push tomasteranddevelop:gofmt -lcheck,go vet ./..., andgo test ./.... Repo is already clean on both fronts (go vetandgofmt -lhad no output before this change).Closes #19, closes #20.