Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(exa): review revisions from #266 #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
docs(exa): review revisions from #266 #268
Changes from all commits
10c13ceFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 3 in integrations/exa.mdx
integrations/exa.mdx#L3
Check warning on line 7 in integrations/exa.mdx
integrations/exa.mdx#L7
Check warning on line 7 in integrations/exa.mdx
integrations/exa.mdx#L7
Check warning on line 7 in integrations/exa.mdx
integrations/exa.mdx#L7
Check warning on line 7 in integrations/exa.mdx
integrations/exa.mdx#L7
Check warning on line 7 in integrations/exa.mdx
integrations/exa.mdx#L7
Check warning on line 10 in integrations/exa.mdx
integrations/exa.mdx#L10
Check warning on line 10 in integrations/exa.mdx
integrations/exa.mdx#L10
Check warning on line 10 in integrations/exa.mdx
integrations/exa.mdx#L10
Check warning on line 10 in integrations/exa.mdx
integrations/exa.mdx#L10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOW — Use the exact
live:token for consistency. L75 refers to a`sandbox:`-prefixed key (the exact prefix token), but here it's the looser "live-prefixed". A reader matching prefixes across the page sees two different forms. Changelive-prefixedto`live:`-prefixedso both places use the exact token.Check warning on line 25 in integrations/exa.mdx
integrations/exa.mdx#L25
Check warning on line 27 in integrations/exa.mdx
integrations/exa.mdx#L27
Check warning on line 29 in integrations/exa.mdx
integrations/exa.mdx#L29
Check warning on line 29 in integrations/exa.mdx
integrations/exa.mdx#L29
Check warning on line 30 in integrations/exa.mdx
integrations/exa.mdx#L30
Check warning on line 30 in integrations/exa.mdx
integrations/exa.mdx#L30
Check warning on line 49 in integrations/exa.mdx
integrations/exa.mdx#L49
Check warning on line 57 in integrations/exa.mdx
integrations/exa.mdx#L57
Check warning on line 62 in integrations/exa.mdx
integrations/exa.mdx#L62
Check warning on line 62 in integrations/exa.mdx
integrations/exa.mdx#L62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOW — Ordering vs. the pinned SDK version (non-blocking). The page pins SDK 1.10.0 (L25), and per payments#416 the warning self-fires on 1.10.0 regardless of what the caller passes — so for anyone following this doc verbatim, the self-fire is the default case, not the "something is still passing it" case this row leads with. The row does recover at the end ("if you have removed the option and still see it, that issue is why"), so it's correct as written; but a reader on the documented version will first go hunting for a wrapper/copied example that isn't there. Consider leading with the 1.10.0 behaviour, e.g.:
Purely a most-common-path reordering — flagging, not gating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOW — Row names the cause but not the fix. This entry explains why a
sandbox:key fails but leaves the remedy implicit (it's only stated far up in the Info block at L10). A troubleshooting row reads best when it carries its own fix. Copilot flagged the same (suppressed comment). Suggestion:Check warning on line 77 in integrations/exa.mdx
integrations/exa.mdx#L77
Check warning on line 77 in integrations/exa.mdx
integrations/exa.mdx#L77