Relay the run's commit identity into the sandbox - #94
Merged
Conversation
The sandbox env is built only from `args.env`, so GIT_AUTHOR_*/ GIT_COMMITTER_* set on the pod stopped at the pod boundary. The agent is the one that commits, so what landed in the history was whatever the pack's setup_cmd hardcoded: crucible <crucible@local>, which GitHub attributes to nobody. Relay them on the same terms as the Vertex keys and the agent-visible secrets: set and non-empty crosses, a manifest value wins. Naming no identity relays nothing, so a deploy that sets none is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sandbox env is built only from
args.env, so theGIT_AUTHOR_*the controller stamps on a run pod never reached the agent that actually commits. What landed was the pack's hardcodedcrucible <crucible@local>— see #92, whose commit GitHub attributes to nobody.Relays them like the Vertex keys and the agent-visible secrets: set and non-empty crosses, a manifest value wins, an unset identity relays nothing.
Pairs with crucible-domains#499, which is where the identity gets named.