security: fix critical vulnerabilities (Cypher injection, CORS, auth, token expiry)#1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
- Cypher injection: add _sanitize_label() validation for Neo4j labels/types
in repository.py (4 injection points patched)
- CORS: restrict allow_methods and allow_headers from wildcards to explicit
lists in main.py
- Auth: add authentication to /raw_materials and /input_type/{input_type}
endpoints in flows.py
- Token expiry: reduce from 60*60 min (2.5 days) to 60*24 min (1 day)
in auth.py
- Password validation: add min_length=8, max_length=128 to ProfileCreate
in profile.py
- .env.example: add warning comment about replacing default AUTH_SECRET
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 6 critical security issues found during a codebase audit.
Cypher injection —
Neo4jGraphRepositoryinterpolatednode_type,rel_label,from_type,to_typedirectly into f-string Cypher queries. Added_sanitize_label(value)that validates labels against^[A-Za-z_][A-Za-z0-9_]*$and raisesValueErroron mismatch. Applied at all 4 injection points:_build_node_query,_build_relationship_query,batch_create_edges_by_element_id, andmerge_nodes.CORS wildcards with credentials —
allow_methods=["*"]andallow_headers=["*"]combined withallow_credentials=Trueis dangerous. Restricted to explicit lists:Missing auth on enricher endpoints —
GET /api/flows/raw_materialsandGET /api/flows/input_type/{input_type}had no authentication. Addedcurrent_user: Profile = Depends(get_current_user)to both.Excessive token lifetime —
ACCESS_TOKEN_EXPIRE_MINUTESwas60 * 60(2.5 days). Reduced to60 * 24(1 day).No password validation —
ProfileCreate.passwordaccepted any string. AddedField(..., min_length=8, max_length=128).Weak default secret —
.env.exampleshippedAUTH_SECRET=superscretchangeitplzwithout warning. Added comment withsecrets.token_urlsafe(48)generation command.Link to Devin session: https://app.devin.ai/sessions/16957490aade494488bbb861d2eeb3a1
Requested by: @netty-linux