Validator: relax parameter typehints#244
Open
xificurk wants to merge 2 commits into
Open
Conversation
xificurk
force-pushed
the
validator-typehints
branch
from
April 10, 2020 19:14
7d534d8 to
609763b
Compare
xificurk
force-pushed
the
validator-typehints
branch
from
May 2, 2020 12:02
609763b to
237c9fe
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
May 15, 2020 10:07
dd9d4ef to
458607d
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
June 6, 2020 15:14
ec3633f to
206edb7
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
July 13, 2020 12:18
f305a97 to
215a482
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
July 31, 2020 18:03
4c07b63 to
f59c35e
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
October 15, 2020 20:02
d5e7d21 to
6b69042
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
November 2, 2020 15:52
a358616 to
cfe069b
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
February 11, 2021 03:51
2a41d90 to
54858a9
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
March 4, 2021 20:03
02ad720 to
3dd3d66
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
April 12, 2021 10:45
f57de1d to
d906e2a
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
June 17, 2021 22:08
fa3d392 to
baff035
Compare
dg
force-pushed
the
master
branch
11 times, most recently
from
August 29, 2021 13:05
93eee5a to
7f4b339
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some validation methods of form
Validatorrequire a specifc type of control instead of genericIControlinterface. This means you can't use those validators with custom form controls (e.g. any control based on nextras/form-components). This is especially frustrating for the basic "filled" validator which is used if the form control is marked as required.This PR relaxes the parameter typehints in backward compatible manner to allow validation of custom controls.