Fix spike integration dependence on whether integrate_odes() is called - #1399
Open
clinssen wants to merge 5 commits into
Open
Fix spike integration dependence on whether integrate_odes() is called#1399clinssen wants to merge 5 commits into
clinssen wants to merge 5 commits into
Conversation
clinssen
marked this pull request as draft
July 20, 2026 21:48
added 4 commits
July 21, 2026 00:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1392.
Spikes are no longer (erroneously) added to the membrane potential of the iaf_psc_delta neuron if
integrade_odes()is not called. The model docstring has been corrected.Updated NEST/NESTML model equivalence test to check for receiving spikes during refractory period for iaf_psc_delta model to prevent regressions.