[feature suggestion] Add command-line parameter --nodevice to start Rookie without ADB

[danielmmmm]

Rookie spawns a new console and runs "adb devices" every few seconds when no device is attached. I guess this the only way to detect newly connected Quests. Would it make sense to add another command-line parameter "--nodevice" that would simply never run ADB?
It may sound like a strange request, but the ADB spawning causes high CPU usage on my ancient laptop.

[DeliciousMeatPop]

Rather than adding a separate --nodevice launch flag, i think it makes more sense to use the Disable Sideloading option Rookie already has at the top of the sideload panel and in Settings.

Im wiring it so enabling Disable Sideloading also stops the background adb devices device-check loop and runs adb kill-server, making sure ADB isnt sitting there running or constantly polling when its completely unnecessary. Once sideloading is disabled, Rookie simply wont spin ADB back up until the user intentionally turns sideloading on again.

That covers the exact same download-only, low-CPU use case as --nodevice, but without adding another command-line flag or another switch users have to deal with before launching the app.

I actually think this is a better solution anyway because it can be toggled on or off while Rookie is already running, and the setting persists between launches. If you only use Rookie for downloading, disable sideloading once and ADB stays out of the picture entirely until you decide you need it again.

The constant device polling is probably there in the first place because a lot of people plug their Quest in and expect Rookie to immediately know its there without ever pressing Connect Device. So Rookie keeps checking in the background to make that experience more automatic. Sometimes you really do have to save the user from themselves lol.

This gives both types of users what they need. People who want automatic device detection can leave sideloading enabled and everything works exactly as it does now, while people using Rookie strictly as a downloader can disable sideloading and completely eliminate the unnecessary ADB activity.

So instead of introducing --nodevice, expanding the existing Disable Sideloading behavior seems cleaner, easier for users to understand, and more useful overall.

That being said, i have absolutely no association with this repo, so all i can really do is put in a PR and leave it up to the maintainers to decide whether they want it.

Ill just make sure to bump the PR (#210 ) about 20 times so nobody misses it, like Jah-yee, AKA PartyBoy, the funnest grammar police officer you'll ever meet 🤣