fix(sse): bound the build-notification connection pool - #125
Merged
Conversation
Behind a reverse proxy the notifier's peer is the proxy rather than the browser, so a stream the client abandoned on navigation still looks writable and is never reclaimed by the existing liveness sweep. Cap the pool at 16 and evict the oldest entry, which bounds the pile-up without needing to tell why a stream went stale. Also declares a reconnect delay on the stream so backoff after a dev-server restart is ours rather than the browser default, and adds the first spec for the notifier. The schema's nested `enable` default read as on-by-default when the feature is in fact opt-in, so that description is now explicit. Refs native-federation/native-federation-core#50
Aukevanoost
force-pushed
the
fix/sse-bounded-pool
branch
from
August 8, 2026 08:24
5584da6 to
97ebe1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behind a reverse proxy the notifier's peer is the proxy, not the browser, so a stream the client abandoned on navigation still looks writable and the existing liveness sweep never reclaims it. The pool is now capped at 16, evicting the oldest entry — which bounds the pile-up without needing to tell why a stream went stale.
Also:
buildNotifications.enablecarriesdefault: trueon a nested property, so it only applies once the parent object exists. The schema read as on-by-default when the feature is opt-in; the description now says so. No behaviour change.Refs native-federation/native-federation-core#50