Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe RDF response now includes an ChangesRDF base URI
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 234 234
Lines 6346 6346
Branches 1866 1873 +7
=======================================
Hits 6328 6328
Misses 16 16
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
You will need to refresh the caches since it stores the old rdf base. |
Overview
What is the feature?
RDF response from /kms/concepts should have xml:base="https://gcmd.earthdata.nasa.gov/kms/concept/" in header.
What is the Solution?
Add 'xml:base' to RDF result in getConcepts handler.
What areas of the application does this impact?
/kms/concepts(*)
Testing
http://localhost:3013/concepts
http://localhost:3013/concepts/concept_scheme/instruments
should show 'xml:base' in RDF header
Attachments
N/A
Checklist
Summary by CodeRabbit
New Features
xml:baseattribute.Tests
xml:basein concept responses.