CMR-11419: fix error handling for ES8 query complexity limit

[zimzoom]

Overview

What is the objective?

Fix error handling for query complexity limit change in ES8.

What are the changes?

The "payload too large" error handling has been expanded to cover both the ES7 and ES8 responses.

What areas of the application does this impact?

search-app

Required Checklist

• New and existing unit and int tests pass locally and remotely
• clj-kondo has been run locally and all errors in changed files are corrected
• I have commented my code, particularly in hard-to-understand areas
• I have made changes to the documentation (if necessary)
• My changes generate no new warnings

Additional Checklist

• I have removed unnecessary/dead code and imports in files I have changed
• I have cleaned up integration tests by doing one or more of the following:
  • migrated any are2 tests to are3 in files I have changed
  • de-duped, consolidated, removed dead int tests
  • transformed applicable int tests into unit tests
  • reduced number of system state resets by updating fixtures. Ex) (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

[jaortega527]

The only thing I could think of to improve the exception handling (and it would apply to the whole block) is to also check the status code, but the message checks are so specific I don't think it would make any difference. The regex for both ES7 and ES8 is great. LGTM.

[zimzoom]

The only thing I could think of to improve the exception handling (and it would apply to the whole block) is to also check the status code, but the message checks are so specific I don't think it would make any difference. The regex for both ES7 and ES8 is great. LGTM.

Yeah, I thought about adding this, but ultimately felt like it would be changing two things instead of one since the ES7 version did not check status code. Since another dev feels the same, I am going to go ahead and add it.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.96%. Comparing base (a30c719) to head (a4b6cd1).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
+ Coverage   57.94%   57.96%   +0.02%     
==========================================
  Files        1074     1074              
  Lines       74714    74715       +1     
  Branches     2187     2190       +3     
==========================================
+ Hits        43290    43307      +17     
+ Misses      29381    29359      -22     
- Partials     2043     2049       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.