Close #630 - #631
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ed5561db8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if html_attribute_names.contains(&name) || name.starts_with("aria") || name.starts_with("data") | ||
| { | ||
| return true; |
There was a problem hiding this comment.
When a caller uses the generated ARIA helpers such as .aria_label("Close"), this branch treats IDL reflection property names like ariaLabel as content attributes, and the generator later writes that raw name into the rendered attribute. In HTML this becomes arialabel rather than the required aria-label, so accessible names/states set through the new typed helpers are ignored by assistive technology.
Useful? React with 👍 / 👎.
| let is_svg = node | ||
| .dyn_ref::<web_sys::Element>() | ||
| .and_then(|el| el.namespace_uri()) | ||
| .map(|ns| ns == "http://www.w3.org/2000/svg") | ||
| .unwrap_or(false); |
There was a problem hiding this comment.
When a state update appends children to an existing SVG <foreignObject>, this derives is_svg only from the parent namespace; because foreignObject itself is SVG, appended HTML children such as div or input are created with the SVG namespace. Initial rendering already switches back to HTML for foreignObject children, so dynamic appends diverge from the initial DOM and the embedded HTML will not behave/render correctly.
Useful? React with 👍 / 👎.
1 participant
残タスク