Skip to content

Further improvements for SSL/TLS authenticate#411

Merged
josesimoes merged 1 commit into
nanoframework:mainfrom
josesimoes:improve-secure-connect-accept
Jul 15, 2026
Merged

Further improvements for SSL/TLS authenticate#411
josesimoes merged 1 commit into
nanoframework:mainfrom
josesimoes:improve-secure-connect-accept

Conversation

@josesimoes

Copy link
Copy Markdown
Member

Description

  • Now surfacing detailed exceptions and error codes from secure connect/accept.
  • Add new SslError codes.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Now surfacing detailed exceptions and error codes from secure connect/accept.
- Add new SslError codes.
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

SSL XML documentation now maps authentication failures to SslError values through CryptographicException.ErrorCode, distinguishes certificate and handshake codes, and updates all client/server authentication overloads without changing runtime behavior.

Changes

SSL authentication error documentation

Layer / File(s) Summary
SslError exception and error-code contract
nanoFramework.System.Net/Security/SslError.cs
Documents exception types for handshake-related enum values and explains certificate verification bitmasks versus raw mbedTLS error codes.
Authentication overload documentation
nanoFramework.System.Net/Security/SslStream.cs
Updates all client and server authentication overloads to document CryptographicException.ErrorCode mappings, InvalidOperationException cases, and removal of prior handshake SocketException documentation.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise, within length limits, and accurately reflects the SSL/TLS authentication improvements.
Description check ✅ Passed The description is clearly related to the changes by mentioning detailed exceptions and new SslError codes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@josesimoes

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@josesimoes

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@josesimoes josesimoes changed the title Further improvements for SSL/TLS authenticate (#407) Further improvements for SSL/TLS authenticate Jul 15, 2026
@josesimoes josesimoes merged commit e0b6dbc into nanoframework:main Jul 15, 2026
8 checks passed
@josesimoes josesimoes deleted the improve-secure-connect-accept branch July 15, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants