feat: add alert rule test fire button - #2203
Merged
Merged
Conversation
…ore conditions are met Adds a 'test fire' button beside Save in FormNG. It synthesizes a test event from the current (even unsaved) rule config — using a real Prometheus series sample or a built-in mock — and calls the new backend test-fire endpoint, which walks the real effective/pipeline/mute/notify/ subscribe chain and returns a per-stage report. Notifications are really sent with a [TEST] marker unless dry-run is checked.
…sread form value The form stores notify_recovered as the Switch boolean (converted to 0/1 only by processFormValues on save), so comparing against 1 flagged enabled rules as disabled. Accept both the boolean and numeric forms.
…ecovery notify in test-fire - getDefaultSeverity only looked at rule_config.queries[].severity; ES/SQL plugin datasources and Prometheus V2 keep severity in rule_config.triggers, so the default always fell back to S2 there - render the new recover_notify_disabled notify-stage reason returned by the backend when the rule has recovery notification disabled
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds an alert-rule test-fire modal with configurable event and sample settings, Prometheus series selection, API execution, staged results, localized messages, utility functions, and unit tests. The modal is integrated into the alert-rule form action area. ChangesAlert rule test-fire
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant FormNG
participant TestFireModal
participant PrometheusService
participant AlertRuleTestFireAPI
FormNG->>TestFireModal: open with form values and business group
TestFireModal->>PrometheusService: fetch vector-series data
PrometheusService-->>TestFireModal: return sample series
TestFireModal->>AlertRuleTestFireAPI: submit test-fire payload
AlertRuleTestFireAPI-->>TestFireModal: return event and stage results
TestFireModal-->>FormNG: render result timeline and event details
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…re report The backend now reports when a notify rule's own event pipeline drops the event (so it won't be sent); render it explicitly instead of falling through to a misleading 'not matched'.
Backend no longer emits the subscribe stage; remove it from the stage list, renderer and locales.
…test-fire modal - read the query expression by rule_config.version (V2 stores it in queries[].query, only V1 uses prom_ql), so Prometheus advanced-mode rules can pick a real series instead of silently falling back to mock - guard fetchSeries with a request-id so a slow earlier response can't overwrite a newer one; clear series/selection up front - reset local state on open/close so reopening never echoes stale series, and disable Run while series are loading
…dd query check stage
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/pages/alertRules/FormNG/components/TestFireModal/index.tsx (1)
179-343: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winDefine the alert-rule test-fire response contract before reading stage fields.
TestFireStage.datais typed asRecord<string, any>, butrenderStageDescriptiondepends on backend field names such asq.promql,q.series_count,q.latest_value,tr.exp,tr.fired_groups,data.matched_datasource_ids, anddata.host_count. If the/api/n9e/busi-group/${bgid}/alert-rule/test-fireresponse shape changes, these reads can silently render blank or fallback text instead of failing clearly. Add typed stage detail interfaces or fall back to defensive checks for the fields this UI relies on.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/alertRules/FormNG/components/TestFireModal/index.tsx` around lines 179 - 343, Define typed interfaces or runtime validation for the stage detail payloads consumed by renderStageDescription, covering fields such as matched_datasource_ids, host_count, queries, triggers, promql, series_count, latest_value, exp, and fired_groups. Replace the current unchecked Record<string, any> reads with the validated or typed structures, and provide explicit safe fallback behavior when required fields are missing or malformed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/pages/alertRules/FormNG/components/TestFireModal/index.tsx`:
- Around line 179-343: Define typed interfaces or runtime validation for the
stage detail payloads consumed by renderStageDescription, covering fields such
as matched_datasource_ids, host_count, queries, triggers, promql, series_count,
latest_value, exp, and fired_groups. Replace the current unchecked
Record<string, any> reads with the validated or typed structures, and provide
explicit safe fallback behavior when required fields are missing or malformed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4bce72c9-78d2-48f1-8938-3647beaf04f5
📒 Files selected for processing (9)
src/pages/alertRules/FormNG/components/TestFireModal/index.tsxsrc/pages/alertRules/FormNG/components/TestFireModal/utils.test.tssrc/pages/alertRules/FormNG/components/TestFireModal/utils.tssrc/pages/alertRules/FormNG/index.tsxsrc/pages/alertRules/locale/en_US.tssrc/pages/alertRules/locale/ja_JP.tssrc/pages/alertRules/locale/ru_RU.tssrc/pages/alertRules/locale/zh_CN.tssrc/pages/alertRules/locale/zh_HK.ts
🚧 Files skipped from review as they are similar to previous changes (4)
- src/pages/alertRules/locale/ru_RU.ts
- src/pages/alertRules/locale/zh_HK.ts
- src/pages/alertRules/locale/ja_JP.ts
- src/pages/alertRules/FormNG/components/TestFireModal/utils.ts
模拟触发弹窗的 openModal 把初始化逻辑放在 validateFields().then() 里、catch 只提示 「请先完善必填项」，导致初始化过程中的任何异常都被伪装成校验失败：用户看到必填项提示、 弹窗打不开，控制台没有线索。 改成 then(onOk, onErr) 两参形式，让校验失败与初始化异常分流，两条路径都打印原始错误。 顺带跑 prettier 修正同文件的格式。
jsers
reviewed
Jul 24, 2026
| // datasource_ids 是后端 DB2FE 反填的 Deprecated 展示字段（引擎只认 datasource_queries）。 | ||
| // 表单里没有它的 UI 绑定，留在 values 里会在切换数据源类型后携带旧数据源 id 提交出去， | ||
| // 导致模拟触发解析到错误的数据源 | ||
| delete processed.datasource_ids; |
Collaborator
There was a problem hiding this comment.
应该在上面 processInitialValues 里处理
| form.setFieldsValue(newValues); | ||
| // setFieldsValue 对数组按索引 merge，重置用的空 values:[] 盖不掉旧值 | ||
| //（旧 cate 选中的数据源 id 会残留），这里对 datasource_queries 强制整体替换 | ||
| form.setFields([{ name: 'datasource_queries', value: newValues.datasource_queries }]); |
Collaborator
There was a problem hiding this comment.
还是没搞清楚这个用意，但是可以确定这个会破坏上面数据源配置保存草稿的功能
…ialValues Move the datasource_ids cleanup from FormNG's init useEffect into the shared DB->form transform (processInitialValues), per review feedback. datasource_ids is a deprecated DB2FE field (engine only reads datasource_queries) with no UI binding; stripping it at the transform layer prevents stale datasource ids from being carried into submit / test-fire.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit