Add BSW / Whitworth (BS 84) rounded thread profiles - #84
Open
viewinghood wants to merge 6 commits into
Open
Conversation
Dedicated command with correct basic minors (h = 2/3 H), reproducible generator, and validation artifacts. Addresses review points from PR mwganson#72 without mixing UNC presets and a 55 variant.
Contributor
Author
Contributor
Author
|
Small note on the Test plan: the optional _bsw_validation_plots/... path is no longer in this PR (kept slim like PG). The BSW checks themselves (plots, FreeCAD overlays, McMaster BSF compare) live in my ThreadDefinitions work folders BSW_validation_plots and BSW_McMaster — happy to share if useful. The form graphic above is just the quick visual. |
Keeps geometry checks, FreeCAD overlays, and reference STEPs on the fork for review without relying on local ThreadDefinitions only.
Keep plots, overlays, and McMaster STEPs on branch bsw-validation so PR mwganson#84 stays scoped like PG.
Contributor
Author
|
BSW validation materials (plots, FreeCAD overlays, McMaster STEPs) are on a separate fork branch to keep this PR slim: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Test plan
_bsw_validation_plots/BSW_1095K104_clean_overlay.FCStdoverlay