Surface block-accumulated cost on ApplyStateOutcome - #19
Merged
Conversation
The cost was already computed by evaluate_scripts and gate-checked against maxBlockCost inside it — both validators just dropped the return value. Surface it as Option<u64> so external conformance runners (SANTA/donner) can grade it without reimplementing the state replay. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
block_cost: Option<u64>toApplyStateOutcome—Somewhen scripts were evaluated,Nonewhen skipped (at or below checkpoint height)evaluate_scriptsreturn value instead of discarding itfacts/validation.mdMotivated by SANTA/donner needing the cost as a conformance observable without reimplementing the state replay.
Test plan
cargo test -p ergo-validation— 73 passedcargo clippy -p ergo-validation --all-targets— cleancargo build --workspace— clean🤖 Generated with Claude Code