feat(completion): scope ?Ctrl field-equate completion to the current procedure - #385
Open
geircodes wants to merge 1 commit into
Open
feat(completion): scope ?Ctrl field-equate completion to the current procedure#385geircodes wants to merge 1 commit into
geircodes wants to merge 1 commit into
Conversation
…procedure Typing '?' inside a procedure now offers that procedure's control equates (?OkButton etc.) as completions, scoped to the WINDOW/APPLICATION/REPORT structures declared in the CURRENT procedure only — controls belonging to other procedures' windows are excluded since they aren't reachable from here. - server.ts: register '?' as a completion trigger character - DocumentStructure.ts: getContainerStructuresInProcedure() finds container structures declared inside a given procedure's body, backed by the existing structuresByType index (no extra token walk) - CompletionProvider.ts: handleFieldEquateCompletion() matches a trailing '?'/'?partial', resolves the current procedure via ScopeAnalyzer, and returns only its controls as CompletionItemKind.Constant (a field equate is a compiler-generated EQUATE, same kind already used for hand-written ones)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing '?' inside a procedure now offers that procedure's control equates (?OkButton etc.) as completions, scoped to the WINDOW/APPLICATION/REPORT structures declared in the CURRENT procedure only — controls belonging to other procedures' windows are excluded since they aren't reachable from here.