fix(diagnostics): GROUP is valid as a global PROCEDURE/FUNCTION label - #384
Open
geircodes wants to merge 1 commit into
Open
fix(diagnostics): GROUP is valid as a global PROCEDURE/FUNCTION label#384geircodes wants to merge 1 commit into
geircodes wants to merge 1 commit into
Conversation
GROUP is not a reserved word in Clarion, but validateReservedKeywordLabels' STRUCTURE_ONLY set required it to sit inside an enclosing structure (e.g. a CLASS method) to avoid the "cannot be the label of a PROCEDURE or FUNCTION declaration" diagnostic — it never accounted for GROUP being valid as a label at global, non-nested scope too. Confirmed by compiling and running a top-level, non-nested `Group PROCEDURE()` (declared in MAP, defined normally, called as Group()) against the real Clarion compiler. Removed GROUP from STRUCTURE_ONLY; its only consumer in this file is this exact PROCEDURE/FUNCTION-label check, so the change is fully isolated. The other 27 keywords in STRUCTURE_ONLY are unverified for this same global-scope validity and are deliberately left as-is. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GROUP is not a reserved word in Clarion, but validateReservedKeywordLabels' STRUCTURE_ONLY set required it to sit inside an enclosing structure (e.g. a CLASS method) to avoid the "cannot be the label of a PROCEDURE or FUNCTION declaration" diagnostic — it never accounted for GROUP being valid as a label at global, non-nested scope too.
Confirmed by compiling and running a top-level, non-nested
Group PROCEDURE()(declared in MAP, defined normally, called as Group()) against the real Clarion compiler. Removed GROUP from STRUCTURE_ONLY; its only consumer in this file is this exact PROCEDURE/FUNCTION-label check, so the change is fully isolated.The other 27 keywords in STRUCTURE_ONLY are unverified for this same global-scope validity and are deliberately left as-is.