fix(payments-next): Reinforce subgroup order - #20999
Draft
elizabeth-ilina wants to merge 1 commit into
Draft
Conversation
elizabeth-ilina
force-pushed
the
PAY-3844-reinforce-subgroup-order
branch
3 times, most recently
from
August 11, 2026 16:08
dde3b65 to
5c5dfcb
Compare
Because: * While the subgroup order appeared correct in Strapi, query showed it out-or-order, which happens from time to time This commit: * Updates codebase to reinforce the order in the subgroup by adding Integer field Closes #[PAY-3844](https://mozilla-hub.atlassian.net/browse/PAY-3844)
elizabeth-ilina
force-pushed
the
PAY-3844-reinforce-subgroup-order
branch
from
August 11, 2026 16:50
5c5dfcb to
df5e216
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes #PAY-3844
Checklist
Put an
xin the boxes that applyHow to review (Optional)
To test the changes, in local Strapi, I made 3 offerings, VPN, 123 Foxkeh, 123donepro.

VPN and 123 Foxkeh are tier 10, 123donepro tier 20.
VPN and 123donepro are in a subgroup, 123Foxkeh is not in any subgroup.
Tested:
Having vpn, purchasing 123:
- Can successfully upgrade
-
Having 123donepro, purcahsing vpn:
- "This subscription plan change is not supported" error page
-
Repeating above scnearios while switching the order of the subgroups in the offering to see if results were (correctly) consistent
-
Having vpn, getting foxkeh
- foxkeh is regular checkout, since they're different subgroups
Having foxkeh, getting 123donepro
- regular checkout, since they're different subgroups
have two offerings with the same tier in one subgroup (for ex., 123donepro and 123foxkeh make both tier 10)
- expected: sentry error, customer just sees subscription switch invalid
- is this expected? Or is it an existing/possible case to have two offerings with the same tier in a subgroup?
Key files/areas to focus on:
Suggested review order:
Risky or complex parts:
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.