enum: Allow configuring the sentinel variant name - #1179
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
Adds a sentinel_variant_name enum option (default "Sentinel") plus a matching sentinel-variant-name annotation, so the variant emitted by add_sentinel can be renamed to something like MyEnum_MAX. Closes mozilla#664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664.
The sentinel variant name was hard-coded to
Sentinel. This adds asentinel_variant_nameoption under[enum](default"Sentinel", so existing output is unchanged) and a matchingsentinel-variant-nameannotation for per-enum overrides. Withprefix_with_nameyou can now get names likeColumns_MAXinstead ofColumns_Sentinel.Added a test that covers both the config option and the annotation, plus docs and template entries.