Skip to content

[AC-154] implement fire and forget ads client async - #7531

Draft
thesuzerain wants to merge 13 commits into
mainfrom
AC-154-Implement-fire-and-forget-ads-client-async
Draft

[AC-154] implement fire and forget ads client async#7531
thesuzerain wants to merge 13 commits into
mainfrom
AC-154-Implement-fire-and-forget-ads-client-async

Conversation

@thesuzerain

@thesuzerain thesuzerain commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

This is a draft PR and not yet ready for review.

Discussion points:

I've excluded the following from this PR:

  • The nimbus work, while I will implement in a separate PR. We do want to use nimbus for the various slices of the async work, but because this adds an entirely new set of surface entrypoints, the branching based on nimbus flags will need to happen on the surface layer. (That being said, future slices will be able to use this, so it will still be included, but will be included separately)
  • In an earlier version of this PR, I included a callback ErrorOnlyCallback that would allow the surfaces to receive any errors from the process running in the worker thread. However, in light of the uniffi callbacks issue, it requires a bit of refactoring to ensure these can be passed to the thread and shutdown successfully- possible, but adds a lot to this PR, so I've excluded it for now.
    • As a result, if there are errors in the fire-and-forget functions like RecordClick, the tests currently do not catch them.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant