docs(quoter-bot): propose delegated KMS signer architecture - #213
docs(quoter-bot): propose delegated KMS signer architecture#213haydenshively wants to merge 5 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Devin Review found 2 potential issues.
2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8bd48771f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
julien-devatom
left a comment
There was a problem hiding this comment.
Keep things much more simple: delegate offer signing to a key but keep everything in the bot instance: no lambda function, no dynamodb etc
moreover the tib is really verbose and seems not to follow the principles expressed here : a lot of context is ai written and does not provide so much value (i know my tibs in this repo are also not a good example at all)
Ack, we can do this. On the call it sounded like you'd prefer if the KMS key could only sign (not withdraw, etc.), and this was a way of achieving that without additional smart contracts. If you're ok with standard Midnight-authorization for it, we can simplify a lot. |
Signed-off-by: Hayden Shively <17186559+haydenshively@users.noreply.github.com>
Summary
Verification
Risk
This TIB governs a funds-at-risk signing boundary. The accepted residual risk is explicit: native Midnight delegation is broad, and the dedicated maker capital remains the hard loss boundary while delegation is active.