docs(getservice): mark getService deprecated, document $modx->services - #615
Open
Ibochkarev wants to merge 1 commit into
Open
docs(getservice): mark getService deprecated, document $modx->services#615Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
PhpStorm warns about a 3.1 removal from xPDO phpdoc. The method is still in 3.x and the core still uses it. Point extras at the DI container. Fixes modxorg#449.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
$modx->getService()is deprecated in 3.x. xPDO phpdoc (and PhpStorm) still say it will be removed in 3.1. That did not happen. Mark Hamstra noted on the issue that the method stays because core and extras still call it.The getService page now states the deprecation, keeps the old examples (they still run), and shows the 3.x replacement:
$modx->services->has()/add()/get(), including themodErrorpattern from modxcms/revolution#15807. Upgrade index, class-names, Services, and DI container pages point at the same thing.Checked against Revolution
origin/3.x:xPDO::getService()(@deprecated … Will be removed in 3.1),modX::$services,modX::runProcessor().Affected versions
3.x
Relevant issues
Fixes #449