docs(custom-tvs): keep the pathing plugin on 2.3 and 3.x - #614
Open
Ibochkarev wants to merge 1 commit into
Open
Conversation
The tutorial claimed Namespace would replace OnTVInputRenderList. Skipping the plugin still falls back to a text field on the Resource form. Fixes modxorg#201.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The custom TV tutorial said the pathing plugin would not be needed from MODX 2.3 because Namespace would handle paths. That is wrong. People skipped the plugin and got a text field instead of the Template dropdown.
On Revolution 3.x,
GetInputscan list types from{namespace}/tv/input/, so the type may appear in the TV editor. Rendering on a Resource still goes throughmodTemplateVar::getRenderDirectories('OnTVInputRenderList'). If the plugin does not output the Extra path,getRender()falls back to the core text renderer.The tutorial now says the plugin is required, matches the events it actually handles, and notes the text-field fallback.
Checked against Revolution
origin/3.x:modTemplateVar.php,Processors/Element/TemplateVar/Renders/GetInputs.php.Affected versions
3.x (same trap on 2.2+; the old 2.3 claim is what #201 hit on 2.7.3)
Relevant issues
Fixes #201