docs(resources): document Access checkbox on Resource Groups tab - #613
Open
Ibochkarev wants to merge 1 commit into
Open
docs(resources): document Access checkbox on Resource Groups tab#613Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
The Resources page never explained that Access means group membership, not an ACL grant. Align related pages with the 3.x tab label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Resources page did not say what Access on the Resource Groups tab does. In MODX 3.x that checkbox is membership: checked adds the Resource to the group (
modResourceGroupResource), unchecked removes it. It is not an ACL grant. The page stays public until you attach a User Group and an ACL.Also renamed leftover "Access Permissions" / "Acces" labels on the Resource Groups page and the member-only tutorial so they match the manager tab.
Checked against Revolution
origin/3.x:modx.panel.resource.js,modx.grid.resource.security.local.js,Processors/Resource/{Create,Update,ResourceGroup}.Affected versions
3.x (tab label is the same idea on 2.x, wording follows 3.x)
Relevant issues
Fixes #434