docs(events): Clarify OnWebLogin vs getUser() on web login - #586
Open
Ibochkarev wants to merge 1 commit into
Open
docs(events): Clarify OnWebLogin vs getUser() on web login#586Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Ibochkarev
marked this pull request as ready for review
August 15, 2026 04:19
Collaborator
|
Is this something we should fix in core? Documenting the edge case still makes sense but it seems like #428 warrants looking into the core. |
Document that session contexts exist before OnWebLogin but $modx->user is not refreshed for web contexts. Point plugins at the $user event parameter. Align attributes with Login::fireAfterLoginEvent on 3.x.
cursor
Bot
force-pushed
the
docs/issue-428-onweblogin-getuser
branch
from
August 15, 2026 11:07
62cc3ed to
ea6c795
Compare
Collaborator
Author
Hi! Is it possible to transfer this issue to the modx repository? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs claimed the user is fully “logged in” during
OnWebLogin, which led people to call$modx->getUser()and get the previous (often anonymous) user.On Revolution 3.x,
Login::afterLogin()adds session contexts, then for mgr only resets$modx->userand callsgetUser('mgr', true)beforeOnManagerLogin. For web it invokesOnWebLoginwithout that refresh, so$modx->getUser()still returns the request-cached user.Updates en/ru
OnWebLoginpages: correctattributesshape fromfireAfterLoginEvent(), document thegetUser()caveat, and show using the event$user(or an explicit reload).Affected versions
Both (same Login processor pattern on 2.x/3.x; verified against Revolution 3.x
Processors/Security/Login.php)Relevant issues
Fixes #428