[MOOSE-409] Fix tab block validation via dynamic child tab render - #372
Open
GeoffDusome wants to merge 4 commits into
Open
[MOOSE-409] Fix tab block validation via dynamic child tab render#372GeoffDusome wants to merge 4 commits into
GeoffDusome wants to merge 4 commits into
Conversation
GeoffDusome
requested review from
LayaTaal,
Vinsanity,
dpellenwood,
jamiepaul and
spadilha
July 24, 2026 14:46
GeoffDusome
changed the title
Migrate horizontal/vertical child tab blocks to render.php and share parent controllers under Blocks/Tabs. Wait for child blockId before selecting the default active tab in the editor. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
GeoffDusome
changed the title
spadilha
approved these changes
Jul 29, 2026
spadilha
left a comment
spadilha
left a comment
Contributor
There was a problem hiding this comment.
🟢 Looks good, Geoff! Thanks for applying it to both the Vertical and Horizontal Tabs blocks. This should make them more future-proof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
Fixes Horizontal and Vertical Tabs block validation errors and default active-tab behavior in the editor.
Editors without
unfiltered_htmlhit KSES sanitization on save, which strips attributes (liketabindex) from statically saved tab panel markup and causes block validation errors on the next load. This follows the GUQ approach instead of the earlier omit-tabindex-from-save / reapply-via-JS workaround:horizontal-tabandvertical-tabblocks to dynamicrender.php(save only inner block content)tabs.jsopens the first panelblockIdbefore setting the default active tab in the editorComponents/Blocks/Tabs(Base_Tabs_Block_Controller+ horizontal/vertical subclasses)Jira: https://moderntribe.atlassian.net/browse/MOOSE-409
Related reference: https://github.com/moderntribe/guq/pull/184, https://github.com/moderntribe/guq/pull/187
QA
Links to relevant issues
Screenshots/video:
Preview: https://moose-dev-pr372.d1.moderntribe.qa/
Pull request checklist