refactor: extract the compose reader into read.py#65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the JSON/YAML compose reader out of
cli.pyinto a newcompose2pod/read.pydeep module with a one-function interfaceread(text: str, fmt: str) -> Any. The repo's subtlest logic — the YAML-1.2 (Docker)SafeLoaderthat keeps a bareona string and reads1e3as a float — now has a direct test surface (tests/test_read.py) instead of being reachable only throughmain().cli.pyreturns to argparse glue.read()raises onlyUnsupportedComposeError; the JSON path now wrapsjson.JSONDecodeErrorasinvalid JSON: ...(symmetric with the existinginvalid YAML:) — the one intended, observable change. Every parsed document is otherwise identical; theautofallback (invalid JSON → YAML) is preserved.The move also retargeted the direct importers a first pass missed —
test_cli.py'sTestYaml12*classes andtests/conformance/conftest.pycalled the oldcli._load_yaml/_read_composedirectly — and promoted the stale_read_composereference inarchitecture/supported-subset.md.Rationale and design:
planning/changes/2026-07-15.18-extract-compose-reader.md.Gates:
just test-ci1273 passed @ 100% coverage (read.py42/42,cli.py50/50) ·just lint-ciclean ·just check-planningOK.🤖 Generated with Claude Code