refactor: move environment into the service-key registry#64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the compose
environmentservice key into theSERVICE_KEYSregistry as_map("-e"), deleting its hand-rolled validate (parsing._validate_environment), the-ebranch ofemit._env_flags(renamed_env_file_flags), and its entry inextends._STRUCTURAL_MERGE_KEYS/keys.STRUCTURAL_KEYS.environmentnow has the same single-spec locality (validate + emit + merge in one place) and drift-immunity as its map-shaped twinslabels/annotations.Behavior-preserving. The
-e KEY=valtokens are byte-identical; podman env precedence is by source not command-line order (--envalways beats--env-file, perpodman-run.1), so-emoving after--env-filein the generated script is inert. The one observable change is theextendserror message for a malformed side, now the registry-standard'environment' must be a list or mapping— the drift-close this move exists to deliver.Rationale and design:
planning/changes/2026-07-15.17-environment-into-registry.md.Sits under the narrow revisit licensed by
planning/decisions/2026-07-12-reject-structural-key-registry.md(a single-key move, not a structural-key registry).Gates:
just test-ci1261 passed @ 100% coverage ·just lint-ciclean ·just check-planningOK.architecture/supported-subset.mdpromoted in the same PR.🤖 Generated with Claude Code