Handle missing AgentFlan query for string suffixes - #9949
Open
taking-lying-flat wants to merge 1 commit into
Open
Handle missing AgentFlan query for string suffixes#9949taking-lying-flat wants to merge 1 commit into
taking-lying-flat wants to merge 1 commit into
Conversation
taking-lying-flat
marked this pull request as ready for review
August 19, 2026 11:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculate_loss_scaleto receive a missing queryRoot cause
String template suffixes are processed as assistant contexts, but only response contexts receive the current query. AgentFlan therefore calls
calculate_loss_scalewithquery=Nonefor suffixes. The query-map lookup attemptedkey in querywithout guarding the optional value, raising aTypeErrorduring template encoding.Impact
AgentFlan loss scaling can process string suffixes such as Qwen ChatML's
<|im_end|>\nwhile preserving query-specific loss scaling for response contexts.